Style changes to prevent warnings.

TBF/Rig/Dummy/Balance/Component.cs

@@ -12,25 +12,12 @@ namespace TBF.Rig.Dummy.Balance
     public class Component : ComponentBase, IScale, IOperation
     {
         private static readonly ILog log = LogManager.GetLogger(typeof(Component));
-        public override string ToString()
-        {
-            return string.Format("{0}({1})", this.GetType().Namespace.Substring(8), Cfg.ToString(1));
-        }
-
-        public Component()
-        {
-        }
-
-        public Component(Generic.IComponentCfg cfg)
-            : base(cfg)
-        {
-            log.Warn(this.ToString());
-        }
+        public override string ToString() { return string.Format("{0}({1})", ClassName, Cfg.ToString(1)); }
 
         public int ScaleNr { get { return 0; } }
         public double Capacity { get { return 10000.0; } }
-		public IValve DrainValve { get { return null; } }
-		public IValve DrainValve2 { get { return null; } }
+        public IValve DrainValve { get { return null; } }
+        public IValve DrainValve2 { get { return null; } }
         public bool ContainsMoreThen(float thld) { return (thld == 0); }
         public bool IsEmpty() { return true; }
         public double EvaporationRate(double t) { return 0; }
@@ -40,6 +27,16 @@ namespace TBF.Rig.Dummy.Balance
         public float BuoyancyPress { get { return 1.013f; } }
         public float BuoyancyHumi { get { return 50.0f; } }
 
+
+        public Component() { }
+
+        public Component(Generic.IComponentCfg cfg)
+            : base(cfg)
+        {
+            log.Warn(this.ToString());
+        }
+
+
         public IOperation ZeroOp()
         {
             return this;
@@ -63,9 +60,7 @@ namespace TBF.Rig.Dummy.Balance
         }
 
         /// <summary>Start this operation</summary>
-        public void Start()
-        {
-        }
+        public void Start() { }
 
         /// <summary>Run this operation</summary>
         public Event Run()
@@ -74,8 +69,6 @@ namespace TBF.Rig.Dummy.Balance
         }
 
         /// <summary>Stop this operation</summary>
-        public void Stop()
-        {
-        }
+        public void Stop() { }
     }
 }

TBF/Rig/Dummy/RegValve/RegValve.cs

@@ -8,7 +8,7 @@ using TBF.Boxes;
 
 namespace TBF.Rig.Dummy.RegValve
 {
-    public class RegValve : ComponentBase, IDevice, GenericDevices.IRegValve, SchematicDrawing.IDrawingItCmpnt
+    public class RegValve : ComponentBase, GenericDevices.IRegValve, SchematicDrawing.IDrawingItCmpnt
 	{
 		private static readonly ILog log = LogManager.GetLogger(typeof(RegValve));
         public override string ToString() { return string.Format("RegulValve({0})", Cfg.ToString(-1)); }
@@ -27,24 +27,19 @@ namespace TBF.Rig.Dummy.RegValve
         public IDictionary<double, double> Dict { get { return dict; } }
 
 
-		public RegValve()
-		{
-		}
+		public RegValve() { }
 
 		public RegValve(Generic.IComponentCfg cfg, IList<Generic.IComponent> components)
             : base(cfg)
 		{
 			RegulValveCfg = cfg as RegValveCfg;
-            dict = new Dictionary<double, double>();
-
             log.Warn(this.ToString());
 		}
 
-        public void Initialize()      { }
-        public void RunDeviceBefore() { }
-        public void RunDeviceAfter()  { }
-        public void StopDevice()      { }
-		public void StopDevice2()	  { }
+        public override void Initialize()
+        {
+            dict = new Dictionary<double, double>();
+        }
 
 
         /// <summary>

TBF/Rig/Dummy/RegValve/RegulValveCfgCtrl.cs

@@ -1,5 +1,5 @@
 ///
-/// Copyright (c) 2017 Sensus Metering Systems
+/// Copyright (c) 2017 Sensus Slovensko a.s.
 ///
 using System;
 using System.Windows.Forms;
@@ -11,8 +11,6 @@ namespace TBF.Rig.Dummy.RegValve
 {
 	public partial class RegulValveCfgCtrl : UserControl, IComponentCfgCtrl
 	{
-		ComponentParametersDlg parent;
-
 		public bool ShowMore { get { return true; } }
 
 		RegValveCfg config;

TBF/Rig/Dummy/RegValve/SetRegValvePositionOp.cs

@@ -1,5 +1,5 @@
 ///
-/// Copyright (c) 2017 Sensus Metering Systems
+/// Copyright (c) 2017 Sensus Slovensko a.s.
 ///
 using System;
 using System.Collections.Generic;
@@ -35,7 +35,6 @@ namespace TBF.Rig.Dummy.RegValve
         readonly int timeout;
 
         ///  Process values
-        bool firstRun;
         int expireTime;
 		bool positionReached;
 
@@ -56,7 +55,6 @@ namespace TBF.Rig.Dummy.RegValve
 
 			this.posLoPct = posLoPct;
             this.posHiPct = posHiPct;
-
             this.timeout = timeout;
 			
 			log.Debug(this.ToString());
@@ -74,7 +72,6 @@ namespace TBF.Rig.Dummy.RegValve
 		/// <summary>Start this operation</summary>
 		public void Start()
         {
-            firstRun = true;
             positionReached = false;
             expireTime = StateMachine.Time + timeout;
             log.InfoFormat("Start(): RV#={0}, reqPosLo={1}%, reqPosHi={2}%", posLoPct.ToString("F1"), posHiPct.ToString("F1"));
@@ -111,8 +108,6 @@ namespace TBF.Rig.Dummy.RegValve
 		}
 
         /// <summary>Stop this operation</summary>
-        public void Stop()
-		{
-        }
+        public void Stop() { }
 	}
 }

TBF/Rig/Dummy/Valve/Component.cs

@@ -27,9 +27,7 @@ namespace TBF.Rig.Dummy.Valve
             log.Warn(this.ToString());
         }
 
-		bool state;
-
-		public bool State { get { return state; } }
+		public bool State { get { return false; } }
 		public ValveCategory Category { get { return ValveCategory.None; } }
 		public int Delay { get { return 1; } }
 		public IValve CoupledTo { get { return null; } }