michal/tbf
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add - Store and log default PumpPower for dynamic test repetitions - Read PumpPower from the current pump before starting dynamic tests.

Browse Source 
- Store the value as the default PumpPower for subsequent test instances in the cycle.
- Add logging when PumpPower is initialized from the pump.
- Add logging at test start including test name, repetition number,
  last repetition flag, and PumpPower to improve diagnostics.
This commit is contained in:
Marek Frniak 2026-07-15 11:35:32 +02:00
parent 37c89a4c9c
commit 38973e0030
2 changed files with 44 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
TBF/Rig/TestMethods/FlyingStartMassCollection/FlyingStartMassCollectionSeq.cs
View File

@ -153,8 +153,16 @@ namespace TBF.Rig.TestMethods.FlyingStartMassCollection
int totalPulses = Convert.ToInt32(test.Volume / outPath.FlowMeter.LtrPerPulse);
log.InfoFormat(
"{0}({1}) : Test starting... (Repetition {2}, LastRepetition={3}, PumpPower={4})",
test.Method,
test.Name,
repetitionNr,
isLastRepetition,
test.PumpPower);
///============================================================================================
/// Read pressure and temperature once before calling Bridge.OnTestSelected(...)
State.Create(string.Format("{0}({1}) : Measuring process data", test.Method, test.Name))
.AddOperation(checkUiOp)
@ -453,7 +461,19 @@ namespace TBF.Rig.TestMethods.FlyingStartMassCollection
}
}
}
///
/// reading pump power for dynamic using as default test.PumpPower for next test instances in cycle
///
if (inPath.Pump is IPump)
{
test.PumpPower = (float)(inPath.Pump as IPump).Power;
log.InfoFormat(
"PumpPower initialized from operator to '{0}'%",
test.PumpPower);
}
// if (atleastOneGenesis)
// {
// log.Info($"Genesis - Starting... Test Name:{test.Name.ToLower()}.");
@ -472,7 +492,7 @@ namespace TBF.Rig.TestMethods.FlyingStartMassCollection
// }
// }
if (drainTheTank)
if (drainTheTank)
{
//------------------------------------------------
Bridge.OnActivity(this, Strings.Closing_the_tank);

21
TBF/Rig/TestMethods/StandingStartMassCollection/StandingStartMassCollectionSeq.cs
View File

@ -149,6 +149,14 @@ namespace TBF.Rig.TestMethods.StandingStartMassCollection
int totalPulses = Convert.ToInt32(test.Volume / outPath.FlowMeter.LtrPerPulse);
log.InfoFormat(
"{0}({1}) : Test starting (Repetition {2}, LastRepetition={3}, PumpPower={4})",
test.Method,
test.Name,
repetitionNr,
isLastRepetition,
test.PumpPower);
///============================================================================================
/// Read pressure and temperature once before calling Bridge.OnTestSelected(...)
@ -435,6 +443,19 @@ namespace TBF.Rig.TestMethods.StandingStartMassCollection
/// Temperature is withing required range at this point
///
///
/// reading pump power for dynamic using as default test.PumpPower for next test instances in cycle
///
if (inPath.Pump is IPump)
{
test.PumpPower = (float)(inPath.Pump as IPump).Power;
log.InfoFormat(
"PumpPower initialized from operator to '{0}'%",
test.PumpPower);
}
//-----------------------------------------------------------------
Bridge.OnActivity(this, Strings.Stopping_flow_for_the_fixed_start);
//-----------------------------------------------------------------