diff --git a/Common/Hardware/WaterMeter/Genesis/DataPackages/MeasurementRecords/CalibrationRecord.cs b/Common/Hardware/WaterMeter/Genesis/DataPackages/MeasurementRecords/CalibrationRecord.cs index 8b61aebd..5211dff8 100644 --- a/Common/Hardware/WaterMeter/Genesis/DataPackages/MeasurementRecords/CalibrationRecord.cs +++ b/Common/Hardware/WaterMeter/Genesis/DataPackages/MeasurementRecords/CalibrationRecord.cs @@ -1,6 +1,5 @@ using System; using System.Text; -using Xylem.Common.CommonCore.Consts; using Xylem.Common.Metrology.Measurements; namespace Xylem.Common.Hardware.WaterMeter.Genesis.DataPackages.MeasurementRecords @@ -31,12 +30,12 @@ namespace Xylem.Common.Hardware.WaterMeter.Genesis.DataPackages.MeasurementRecor /// /// total time of flight in cordonel units /// - public Int32 RAWTotalTimeOfFlight; + public Int32 RawTotalTimeOfFlight; /// /// delta time of flight in cordonel units /// - public Int32 RAWDeltaTimeOfFlight; + public Int32 RawDeltaTimeOfFlight; /// /// volume scale (default: 1024) means diff --git a/Common/Hardware/WaterMeter/Genesis/DataPackages/RadioConfigurationParams.cs b/Common/Hardware/WaterMeter/Genesis/DataPackages/RadioConfigurationParams.cs index dc54c9d2..1d96b541 100644 --- a/Common/Hardware/WaterMeter/Genesis/DataPackages/RadioConfigurationParams.cs +++ b/Common/Hardware/WaterMeter/Genesis/DataPackages/RadioConfigurationParams.cs @@ -1,21 +1,49 @@ using System; -using System.Collections.Generic; -using System.Text; namespace Xylem.Common.Hardware.WaterMeter.Genesis.DataPackages { - //obs + + /// + /// All parameters needed for radio setup + /// public class RadioConfigurationParams { - public string PcbId; + /// + /// Pcb identification + /// + public String PcbId; + /// + /// Serial number + /// public UInt32 SerialNumber; + /// + /// Radio address + /// public UInt32 RadioAddress; + /// + /// Power level + /// public UInt32 PowerLevel; + /// + /// Power level option + /// public UInt32 PowerLevelOption; + /// + /// New code for impedance + /// public UInt32 ImpedanceCodeNew; + /// + /// Impedance code option + /// public UInt32 ImpedanceCodeOption; + /// + /// Encryption key + /// public Byte[] EncryptionKey; - public short? FrqOffset { get; set; } + /// + /// Frequency offset + /// + public Int16? FrqOffset { get; set; } } } diff --git a/Common/Hardware/WaterMeter/Genesis/DataPackages/RegisterToDb.cs b/Common/Hardware/WaterMeter/Genesis/DataPackages/RegisterToDb.cs index 043a05c4..cdd4d56b 100644 --- a/Common/Hardware/WaterMeter/Genesis/DataPackages/RegisterToDb.cs +++ b/Common/Hardware/WaterMeter/Genesis/DataPackages/RegisterToDb.cs @@ -1,17 +1,29 @@ using System; -using System.Collections.Generic; -using System.Text; namespace Xylem.Common.Hardware.WaterMeter.Genesis.DataPackages { + /// + /// + /// public class RegisterToDb { - public RegisterToDb(byte[] adresse, byte[] value) + /// + /// Register address and value to DB + /// + /// + /// + public RegisterToDb(Byte[] adresse, Byte[] value) { Adresse = adresse; Value = value; } - public byte[] Adresse; - public byte[] Value; + /// + /// Address + /// + public Byte[] Adresse; + /// + /// Value + /// + public Byte[] Value; } } diff --git a/Common/Hardware/WaterMeter/Genesis/DataPackages/TempTofCalc.cs b/Common/Hardware/WaterMeter/Genesis/DataPackages/TempTofCalc.cs index db65608e..ef9ffabe 100644 --- a/Common/Hardware/WaterMeter/Genesis/DataPackages/TempTofCalc.cs +++ b/Common/Hardware/WaterMeter/Genesis/DataPackages/TempTofCalc.cs @@ -1,18 +1,27 @@ using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; namespace Xylem.Common.Hardware.WaterMeter.Genesis.DataPackages { + /// + /// Temperature Time Of Flight calculation + /// public struct TempTofCalc { - private DateTime refDate; - private double refTemp; - private double tof; + private DateTime _refDate; + private Double _refTemp; + private Double _tof; - public DateTime RefDate { get => refDate; set => refDate = value; } - public double RefTemp { get => refTemp; set => refTemp = value; } - public double Tof { get => tof; set => tof = value; } + /// + /// Reference data + /// + public DateTime RefDate { get => _refDate; set => _refDate = value; } + /// + /// Reference temperature + /// + public Double RefTemp { get => _refTemp; set => _refTemp = value; } + /// + /// Time Of Flight + /// + public Double Tof { get => _tof; set => _tof = value; } } } diff --git a/Common/Hardware/WaterMeter/Genesis/Protocols/StreamingProtocol/StreamingDecoder.cs b/Common/Hardware/WaterMeter/Genesis/Protocols/StreamingProtocol/StreamingDecoder.cs index 233e191e..c8542806 100644 --- a/Common/Hardware/WaterMeter/Genesis/Protocols/StreamingProtocol/StreamingDecoder.cs +++ b/Common/Hardware/WaterMeter/Genesis/Protocols/StreamingProtocol/StreamingDecoder.cs @@ -371,9 +371,9 @@ namespace Xylem.Common.Hardware.WaterMeter.Genesis.Protocols.StreamingProtocol - dataProtHRec.RAWTotalTimeOfFlight = + dataProtHRec.RawTotalTimeOfFlight = int.Parse(field[(Int32)ProtHsubString.Ttof], NumberStyles.AllowHexSpecifier); - dataProtHRec.RAWDeltaTimeOfFlight = int.Parse(field[(Int32)ProtHsubString.Dtof], NumberStyles.AllowHexSpecifier); + dataProtHRec.RawDeltaTimeOfFlight = int.Parse(field[(Int32)ProtHsubString.Dtof], NumberStyles.AllowHexSpecifier); //Delta raw volume between two samples dataProtHRec.DeltaVolumeRaw = uint.Parse(field[(Int32)ProtHsubString.RawDVolume],